Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12345#discussion_r59637760
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -153,16 +153,36 @@ class BenchmarkWholeStageCodegen extends
SparkFunSuite {
ignore("aggregate with keys") {
val N = 20 << 20
- runBenchmark("Aggregate w keys", N) {
- sqlContext.range(N).selectExpr("(id & 65535) as
k").groupBy("k").sum().collect()
+ val benchmark = new Benchmark("Aggregate w keys", N)
--- End diff --
Extended `testFallbackStartsAt` to now support 2 offsets (for aggregate
hash map and bytes to bytes map) and modified `AggregationQuerySuite` such that
all existing tests test for all new codepaths.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
