Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12345#discussion_r59649610
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
 ---
    @@ -484,13 +497,42 @@ case class TungstenAggregate(
         // so `copyResult` should be reset to `false`.
         ctx.copyResult = false
     
    +    def outputFromGeneratedMap: Option[String] = {
    +      if (isAggregateHashMapEnabled) {
    +        val row = ctx.freshName("aggregateHashMapRow")
    --- End diff --
    
    Comment at a high level what this is doing. Something like. " Iterate over 
the aggregate rows and convert them from ColumnarBatch.Row to UnsafeRow"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to