Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/12345#discussion_r59649827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
@@ -513,8 +555,11 @@ case class TungstenAggregate(
ctx.currentVars = input
val keyCode = GenerateUnsafeProjection.createCode(
--- End diff --
I think we can do better with the variable names to improve readability.
keyCode, groupByKeys, key all sound too similar. Add row or unsafe row to
the keys that have been collected to an unsafe row or differentiate them
somehow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
