Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210307663
Hey @holdenk, in
https://github.com/apache/spark/pull/12079#issuecomment-209049583 and
https://github.com/apache/spark/pull/12308#issuecomment-209039855, we decided
to keep them separate for now, since the doc for `binary` in `CountVectorizer`
mentions that the binarization occurs after `minTF` is applied. In `HashingTF`
this doesn't apply as there is no `minTF` parameter.
So unless we can easily have different doc string, I think it might be best
to not separate out `binary` into a shared param yet. We could look at adding
`minTF` semantics to `hashingTF`, in which case it would then make a lot of
sense to have this as a shared param.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
