Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r59864380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -355,6 +355,7 @@ abstract class UnixTime extends BinaryExpression with
ExpectsInputTypes {
override def nullable: Boolean = true
private lazy val constFormat: UTF8String =
right.eval().asInstanceOf[UTF8String]
+ private var formatter: SimpleDateFormat = _
--- End diff --
Not sure this is worth changing, but `...: DateFormat = null`? I actually
am not familiar with the convention for when to use _ vs null. I thought = _
was mostly for defs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
