Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12400#discussion_r60067747
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -104,8 +107,8 @@ private[classification] trait LogisticRegressionParams
extends ProbabilisticClas
* @group setParam
*/
def setThresholds(value: Array[Double]): this.type = {
- if (isSet(threshold)) clear(threshold)
- set(thresholds, value)
+ logWarning("Ignoring setThresholds(), use setThreshold() for binary
Logistic Regression.")
--- End diff --
If we're going to include this patch, it makes most sense to me to remove
the note entirely. When this functionality is restored, we can add back the
note. From what I've seen, comments should not reference future "plans" since
plans like that often change. JMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
