Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12400#discussion_r60082987
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -104,8 +107,8 @@ private[classification] trait LogisticRegressionParams
extends ProbabilisticClas
* @group setParam
*/
def setThresholds(value: Array[Double]): this.type = {
- if (isSet(threshold)) clear(threshold)
- set(thresholds, value)
+ logWarning("Ignoring setThresholds(), use setThreshold() for binary
Logistic Regression.")
--- End diff --
+1 @sethah . I think it will have different meanings compared with the
existing ```setThresholds``` when it will be re-enabled for supporting
multi-class logistic regression. So it's better to remove the note entirely or
just left the doc "It will be re-enabled once multi-class logistic regression
is included".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
