Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12490#discussion_r60183184
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorterSuite.java
---
@@ -70,14 +73,15 @@ public void testBasicSorting() throws Exception {
new TaskMemoryManager(new TestMemoryManager(conf), 0);
final MemoryBlock dataPage = memoryManager.allocatePage(2048, null);
final Object baseObject = dataPage.getBaseObject();
- final ShuffleInMemorySorter sorter = new
ShuffleInMemorySorter(consumer, 4);
+ final ShuffleInMemorySorter sorter = new ShuffleInMemorySorter(
+ consumer, 4, shouldUseRadixSort());
final HashPartitioner hashPartitioner = new HashPartitioner(4);
// Write the records into the data page and store pointers into the
sorter
long position = dataPage.getBaseOffset();
for (String str : dataToSort) {
if (!sorter.hasSpaceForAnotherRecord()) {
-
sorter.expandPointerArray(consumer.allocateArray(sorter.numRecords() * 2));
+
sorter.expandPointerArray(consumer.allocateArray(sorter.getMemoryUsage() / 8 *
2));
--- End diff --
explain what / 8 * 2 does
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
