Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12490#discussion_r60265463
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -148,7 +157,12 @@ public void loadNext() {
* Return an iterator over record pointers in sorted order.
*/
public ShuffleSorterIterator getSortedIterator() {
- sorter.sort(array, 0, pos, SORT_COMPARATOR);
- return new ShuffleSorterIterator(pos, array);
+ int offset = 0;
+ if (useRadixSort) {
+ offset = RadixSort.sort(array, pos, 5, 7, false, false);
--- End diff --
For my understanding. The 5-7 means that we are sorting longs based on
their least significant 4-bytes? Perhaps add some documentation here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
