Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11635#discussion_r60436445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -958,6 +958,25 @@ object PushDownPredicate extends Rule[LogicalPlan]
with PredicateHelper {
project.copy(child = Filter(replaceAlias(condition, aliasMap),
grandChild))
+ // Push [[Filter]] operators through [[Window]] operators. Parts of
the predicate that can be
+ // pushed beneath must satisfy three conditions:
+ // 1. All the columns are part of window partitioning key.
+ // 2. Window partitioning key should be just a sequence of
[[AttributeReference]].
+ // 3. Deterministic
+ case filter @ Filter(condition, w: Window)
+ if w.partitionSpec.forall(_.isInstanceOf[AttributeReference]) =>
+ val partitionAttrs =
AttributeSet(w.partitionSpec.flatMap(_.references))
+ val (pushDown, stayUp) =
splitConjunctivePredicates(condition).partition { cond =>
+ cond.references.subsetOf(partitionAttrs) && cond.deterministic
--- End diff --
This is not right. Will fix it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
