Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11635#discussion_r60461069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -958,6 +958,26 @@ object PushDownPredicate extends Rule[LogicalPlan]
with PredicateHelper {
project.copy(child = Filter(replaceAlias(condition, aliasMap),
grandChild))
+ // Push [[Filter]] operators through [[Window]] operators. Parts of
the predicate that can be
+ // pushed beneath must satisfy three conditions:
+ // 1. involving one and only one column that is part of window
partitioning key.
+ // 2. Window partitioning key should be just a sequence of
[[AttributeReference]].
--- End diff --
Yeah, thank you very much! I just added an extra condition to ensure that
Analyzer converts all the compound expressions to alias. Added a couple of test
cases to ensure it.
To enable predicate push down when the partitioning columns is `a + b` and
the predicate is `a + b > 3`, we need to add a rule in Analyzer for converting
the expressions to the underlying alias that has the exactly same original
expressions. This will be submitted in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
