Github user avati commented on a diff in the pull request:

    https://github.com/apache/spark/pull/996#discussion_r15679675
  
    --- Diff: assembly/pom.xml ---
    @@ -26,7 +26,7 @@
       </parent>
     
       <groupId>org.apache.spark</groupId>
    -  <artifactId>spark-assembly_2.10</artifactId>
    +  <artifactId>spark-assembly_${scala.binary.version}</artifactId>
    --- End diff --
    
    Using ${scala.binary.version} in artifactId gives the following warning in 
maven:
    
    [WARNING] 
    [WARNING] Some problems were encountered while building the effective model 
for org.apache.spark:spark-core_2.11:jar:1.1.0-SNAPSHOT
    [WARNING] 'artifactId' contains an expression but should be a constant. @ 
org.apache.spark:spark-core_${scala.binary.version}:1.1.0-SNAPSHOT, 
/Users/avati/work/spark/core/pom.xml, line 29, column 15
    [WARNING] 
    [WARNING] It is highly recommended to fix these problems because they 
threaten the stability of your build.
    [WARNING] 
    [WARNING] For this reason, future Maven versions might no longer support 
building such malformed projects.
    [WARNING] 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to