Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12537#discussion_r60577678 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala --- @@ -30,13 +64,22 @@ class TableIdentifierParserSuite extends SparkFunSuite { // Illegal names. intercept[ParseException](parseTableIdentifier("")) intercept[ParseException](parseTableIdentifier("d.q.g")) + } + test("table identifier - keywords") { // SQL Keywords. - val keywords = Seq("select", "from", "where", "left", "right") + val keywords = Seq("select", "from", "where") ++ hiveNonReservedRegression keywords.foreach { keyword => intercept[ParseException](parseTableIdentifier(keyword)) assert(TableIdentifier(keyword) === parseTableIdentifier(s"`$keyword`")) assert(TableIdentifier(keyword, Option("db")) === parseTableIdentifier(s"db.`$keyword`")) } } + + test("table identifier - non reserved keywords") { + // Hive keywords are allowed. + hiveNonReservedKeyword.foreach { nonReserved => + assert(TableIdentifier(nonReserved) === parseTableIdentifier(nonReserved)) + } + } --- End diff -- I am just thinking if we can capture it during the Parser? The idea is to issue a better error message when users input an incorrect error message. How about relaxing the `.g4` parsing rule for `tableIdentifier`? That is, allowing `Parser` to accept the illegal inputs? Then, verify its correctness in the `visitTableIdentifier`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org