Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12537#discussion_r60759903
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
---
@@ -30,13 +64,22 @@ class TableIdentifierParserSuite extends SparkFunSuite {
// Illegal names.
intercept[ParseException](parseTableIdentifier(""))
intercept[ParseException](parseTableIdentifier("d.q.g"))
+ }
+ test("table identifier - keywords") {
// SQL Keywords.
- val keywords = Seq("select", "from", "where", "left", "right")
+ val keywords = Seq("select", "from", "where") ++
hiveNonReservedRegression
keywords.foreach { keyword =>
intercept[ParseException](parseTableIdentifier(keyword))
assert(TableIdentifier(keyword) ===
parseTableIdentifier(s"`$keyword`"))
assert(TableIdentifier(keyword, Option("db")) ===
parseTableIdentifier(s"db.`$keyword`"))
}
}
+
+ test("table identifier - non reserved keywords") {
+ // Hive keywords are allowed.
+ hiveNonReservedKeyword.foreach { nonReserved =>
+ assert(TableIdentifier(nonReserved) ===
parseTableIdentifier(nonReserved))
+ }
+ }
--- End diff --
Thank you! @hvanhovell I see your points. Fortunately, Hive metastore does
not enforce it. Otherwise, we are still unable to have names starting with
underscores.
Since we are unable to trust Hive metastore APIs to issue exceptions if we
inputting the illegal inputs, I am trying to see if anything we did is not
consistent with Hive. Otherwise, it could cause a disaster result. For example,
one of them is https://github.com/apache/spark/pull/12446. We could drop all
the partitions if users input a wrong partition column name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
