Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/1678#discussion_r15682389
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleWriter.scala ---
@@ -120,8 +121,7 @@ private[spark] class HashShuffleWriter[K, V](
private def revertWrites(): Unit = {
if (shuffle != null && shuffle.writers != null) {
for (writer <- shuffle.writers) {
- writer.revertPartialWrites()
- writer.close()
+ writer.revertPartialWritesAndClose()
--- End diff --
revert can throw exception : which will cause other writers to not revert.
We need to wrap it in try/catch, log and continue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
