Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1678#discussion_r15682605
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
@@ -147,28 +147,36 @@ private[spark] class DiskBlockObjectWriter(
override def isOpen: Boolean = objOut != null
- override def commit(): Long = {
+ override def commitAndClose(): Unit = {
--- End diff --
Absolutely -- I did not do that in this patch because ExternalAppendOnlyMap
did a close without a commit, which is a fix outside of the scope of this PR,
but definitely one that should be made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
