Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60613340
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -186,7 +186,12 @@ public void testFetchThreeSort() throws Exception {
@Test
public void testFetchInvalidShuffle() throws Exception {
- registerExecutor("exec-1", dataContext0.createExecutorInfo("unknown
sort manager"));
+ try {
--- End diff --
I think this test the way it's written doesn't make much sense any more
since registerExecutor throws an exception. Personally, I'd prefer if we
stopped checked for blocks being empty, and rather assert that the correct type
of exception with the correct message is being thrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
