Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60613929
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -183,12 +190,7 @@ public ManagedBuffer getBlockData(String appId, String
execId, String blockId) {
String.format("Executor is not registered (appId=%s, execId=%s)",
appId, execId));
}
- if ("sort".equals(executor.shuffleManager) ||
"tungsten-sort".equals(executor.shuffleManager)) {
- return getSortBasedShuffleBlockData(executor, shuffleId, mapId,
reduceId);
- } else {
- throw new UnsupportedOperationException(
- "Unsupported shuffle manager: " + executor.shuffleManager);
- }
+ return getSortBasedShuffleBlockData(executor, shuffleId, mapId,
reduceId);
--- End diff --
Personally I'd prefer an assert or similar on the shuffleManager here. What
do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
