Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213176921
Hmm, maybe you need to add the project or config too? As in "set
lintOnCompile in project in Config := true"? Sbt isn't too friendly when
setting command line options in an interactive session.
Regarding your first question, you're correct that the validate task would
not integrate into the DAG of existing tasks like `~sql/test-only`. The
question is whether you actually want that though?
The main issue I see is that hooking into compile makes things more
complicated for developers wanting to do quick and dirty prototyping, and does
not really correspond to the meaning of "compile" that people used to sbt might
expect. I see the advantages of integrated stylechecking though (I forget it
often myself), I just don't think it should be integrated into compiling.
As a compromise, what do you think of adding style and other validation
into the `package` task? It is run far less frequently during normal
development but I still usually run it once before submitting a PR.
As a comprom
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
