Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213125258
It's unfortunate that you need so much code for something that should be
simple, but well. Only minor issues I see are:
- IIUC, changing the scalastyle configuration will not make sbt use the new
rules; you'd need to restart sbt. Correct? Given how rarely that changes, it's
probably ok.
- It'd be nice if you could disable or enable the checks inside an existing
sbt session, instead of having to exit sbt and change the env variable. But
also not a big deal, especially with the println changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
