Github user jodersky commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12605#discussion_r60700548
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
    @@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
     /**
      * Contains utilities for working with posix signals.
      */
    -private[spark] object Signaling extends Logging {
    +private[spark] object SignalUtils extends Logging {
    +
    +  private var registered = false
    +
    +  /** Register a signal handler to log signals on UNIX-like systems. */
    +  def registerLogger(log: Logger): Unit = synchronized {
    --- End diff --
    
    I specifically kept logging separate as it is a specific use case of 
signaling, whereas my original Signaling object just provided the base 
functionality of registering arbitrary functions to be called on signals.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to