Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12605#discussion_r60701675
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
    @@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
     /**
      * Contains utilities for working with posix signals.
      */
    -private[spark] object Signaling extends Logging {
    +private[spark] object SignalUtils extends Logging {
    +
    +  private var registered = false
    +
    +  /** Register a signal handler to log signals on UNIX-like systems. */
    +  def registerLogger(log: Logger): Unit = synchronized {
    --- End diff --
    
    think about it for a second: with your definition we should probably have ~ 
1 million files in spark, since every function is doing something slightly 
different.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to