Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60702234
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -51,11 +88,8 @@ private[spark] object Signaling extends Logging {
// register old handler, will receive incoming signals while this
handler is running
Signal.handle(signal, prevHandler)
- val escalate = actions.asScala forall { action =>
- !action()
- }
-
- if(escalate) {
+ val escalate = actions.asScala.forall { action => !action() }
--- End diff --
```scala
/**
* Called when this handler's signal is received. Note that if the same
signal is received
* before this method returns, it is escalated to the previous handler.
*/
override def handle(sig: Signal): Unit = {
// register old handler, will receive incoming signals while this
handler is running
Signal.handle(signal, prevHandler)
// run all actions, escalate to parent handler if no action catches
the signal (i.e. all actions return false)
val escalate = actions.asScala.forall { action => !action() }
if (escalate) {
prevHandler.handle(sig)
}
// re-register this handler
Signal.handle(signal, this)
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
