Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/9207#issuecomment-215324118
ping @jkbradley @mengxr @srowen - thoughts on my suggestion above?
I think the overall gist of this PR is fine, but it seems nicer to me to
actually put a trait for PMMLExportable in the MLWriter for each supported
model class, but I'm ok with either approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
