Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9207#issuecomment-215359267
If the base change is just bringing the `PMMLExportable` trait to ML in a
reasonable form, that seems fine. I might not know enough to know if I'm
missing something, but that much seems fine.
Hm, wouldn't this require updates to more than `KMeansModel`? I'm probably
missing something.
As to whether to continue to evolve the API -- sounds reasonable. On the
other hand, I'm sort of concerned that there are 2-3 serialization mechanisms
for models, not all of which are fully implemented, and implemented slightly
differently across mllib and ml, and making further changes to how it works in
ml seems like it's piling on some complexity. That said -- I myself would
prefer more rather than less PMML support.
So the further changes -- I suppose I'm neutral on for this particular PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
