Github user taoli91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12693#discussion_r61841934
  
    --- Diff: 
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
    @@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends 
Logging {
           if (fs.exists(partitionerFilePath)) {
             val fileInputStream = fs.open(partitionerFilePath, bufferSize)
             val serializer = SparkEnv.get.serializer.newInstance()
    -        val deserializeStream = 
serializer.deserializeStream(fileInputStream)
    +        // make sure that the file is closed if error occurrs during 
deserialization
    +        val deserializeStream =
    --- End diff --
    
    > Sorry, I mean put this in the block below that closes the deserialization 
stream, at best. 
    
    @srowen It seems we need extra code to accommodate the scope problem if 
putting the close in other clauses. Probably it's cleaner to stick with this 
solution. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to