Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r62049286
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Logging {
if (fs.exists(partitionerFilePath)) {
val fileInputStream = fs.open(partitionerFilePath, bufferSize)
val serializer = SparkEnv.get.serializer.newInstance()
- val deserializeStream =
serializer.deserializeStream(fileInputStream)
+ // make sure that the file is closed if error occurrs during
deserialization
+ val deserializeStream =
--- End diff --
Yeah that's what I mean. Well, if I were right that
`serializer.deserializeStream` can't fail, then the existing could would
already be fine, so this suggestion doesn't help unless `fileInputStream` gets
a similar treatment, and that's too complex. I'm curious how that fails given
the current implementation, but, even if it couldn't now, it could in the
future.
You might normally resolve this with nested try blocks; I think streams
aren't supposed to fail if closed twice, so, safe to close the underlying
stream for good measure. Still at that point it's no less complex, so I can see
that this is as clear as anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
