Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12801#discussion_r61968002
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -448,11 +454,19 @@ class SessionCatalog(
*/
def dropPartitions(
tableName: TableIdentifier,
- parts: Seq[TablePartitionSpec],
+ specs: Seq[TablePartitionSpec],
ignoreIfNotExists: Boolean): Unit = {
+ val tableMetadata = getTableMetadata(tableName)
+ // Verify if each part exactly matches the partition spec of the table
definition
+ // Here, we disallow users to drop multiple partition using one spec
for atomicity.
+ // For example, the partial spec a=1 could contains multiple
partitions a=1/b=1 and a=1/b=2
--- End diff --
this comment is really confusing. I thought the whole point of the patch is
to disallow partial specs, e.g. `a=1` in this example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
