Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12309#discussion_r62015242
--- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala ---
@@ -45,7 +47,8 @@ private[spark] class PipedRDD[T: ClassTag](
envVars: Map[String, String],
printPipeContext: (String => Unit) => Unit,
printRDDElement: (T, String => Unit) => Unit,
- separateWorkingDir: Boolean)
+ separateWorkingDir: Boolean,
+ bufferSize: Int)
--- End diff --
This causes a MiMa failure. This could be resolved with a default value for
this arg; normally that would be essential although we could also just exclude
the failure on the missing old method signature. I don't have a strong feeling
but suppose it makes sense to have a default value?
```
[error] * method
pipe(scala.collection.Seq,scala.collection.Map,scala.Function1,scala.Function2,Boolean)org.apache.spark.rdd.RDD
in class org.apache.spark.rdd.RDD does not have a correspondent in current
version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.rdd.RDD.pipe")
[error] * method
pipe(java.util.List,java.util.Map,Boolean,Int)org.apache.spark.api.java.JavaRDD
in trait org.apache.spark.api.java.JavaRDDLike is present only in current
version
[error] filter with:
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.api.java.JavaRDDLike.pipe")
[info] spark-mllib: found 0 potential binary incompatibilities while
checking against org.apache.spark:spark-mllib_2.11:1.6.0 (filtered 498)
```
The other failure in JavaRDDLike can be excluded safely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
