Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12309#discussion_r62166781
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala 
---
    @@ -214,8 +214,8 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] 
extends Serializable {
       /**
        * Applies a function f to each partition of this RDD.
        */
    -  def foreachPartition(f: VoidFunction[java.util.Iterator[T]]) {
    -    rdd.foreachPartition(x => f.call(x.asJava))
    +  def foreachPartition(f: VoidFunction[JIterator[T]]) {
    +    rdd.foreachPartition((x => f.call(x.asJava)))
    --- End diff --
    
    Nit: this added extra parens which aren't needed. If you wouldn't mind, 
while changing this, end the line above with `): Unit = {` to standardize


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to