Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62100086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -57,7 +60,7 @@ case class CreateDatabase(
CatalogDatabase(
databaseName,
comment.getOrElse(""),
- path.getOrElse(catalog.getDefaultDBPath(databaseName)),
+ catalog.createDatabasePath(databaseName, path),
--- End diff --
looking at it again. Seems we do not really need to pass in `path`, right?
Also, how about we keep the name getDefulatDBPath because `createDatabasePath`
implied file system operations (sorry....). But, it will be good to add comment
to this method to explain its purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
