Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12081#discussion_r62103858
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -57,7 +60,7 @@ case class CreateDatabase(
           CatalogDatabase(
             databaseName,
             comment.getOrElse(""),
    -        path.getOrElse(catalog.getDefaultDBPath(databaseName)),
    +        catalog.createDatabasePath(databaseName, path),
    --- End diff --
    
    yeah, actually how is `new Path(p).toString` different from `p`? Looks like 
that is the only functional difference here? If that doesn't do anything then 
let's just revert all these changes here and only commit the test changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to