Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62151072
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,25 @@ class TypedColumn[-T, U](
}
new TypedColumn[T, U](newExpr, encoder)
}
+
+ /** Creates a TypedColumn based on the given expression. */
+ private def withExpr(newExpr: Expression): TypedColumn[T, U] =
+ new TypedColumn[T, U](newExpr, encoder)
+
+ /**
+ * Gives the TypedColumn a name (alias).
+ * If the current TypedColumn has metadata associated with it, this
metadata will be propagated
+ * to the new column.
+ *
+ * @group expr_ops
+ * @since 2.0.0
+ */
+ override def as(alias: String): TypedColumn[T, U] = withExpr {
--- End diff --
@rxin @cloud-fan : Thanks very much. I have made the changes based on your
comments. Can you help check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
