Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62279165
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -883,7 +895,7 @@ class Column(protected[sql] val expr: Expression)
extends Logging {
* @group expr_ops
* @since 1.4.0
*/
- def as(aliases: Seq[String]): Column = withExpr { MultiAlias(expr,
aliases) }
+ def as(aliases: Seq[String]): Column = name(aliases)
--- End diff --
Sorry I didn't make it clearly: delegate to `def name(alias: String)` if we
can. For this one, we don't need to touch it as it doesn't make sense to call
in on `TypedColumn`.
The reason I want to make as more as possible alias methods delegate to
`def name(alias: String)` is: we don't need to override all of them in
`TypedColumn`, but just the `name`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
