Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12928#discussion_r62168766
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -155,10 +155,10 @@ private[spark] class Client(
     
           // Get a new application from our RM
           val newApp = yarnClient.createApplication()
    -      val newAppResponse = newApp.getNewApplicationResponse()
    -      appId = newAppResponse.getApplicationId()
    +      val newAppResponse = newApp.getNewApplicationResponse
    --- End diff --
    
    These are Java methods? I think it's canonical to call them with empty 
args. Not worth changing anyway


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to