Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62170253
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -168,7 +168,7 @@ private[spark] class Client(
val appContext = createApplicationSubmissionContext(newApp,
containerContext)
// Finally, submit and monitor the application
- logInfo(s"Submitting application ${appId.getId} to ResourceManager")
+ logInfo(s"Submitting application $appId to ResourceManager")
--- End diff --
It's inconsistent with the other log messages where `appId` is printed out
instead. It then makes tracing the calls slightly harder - cf.
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala#L180-L182
and
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala#L174-L175
and few other places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
