Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12919#discussion_r62224157
--- Diff: python/pyspark/ml/regression.py ---
@@ -743,6 +743,18 @@ def treeWeights(self):
"""Return the weights for each tree"""
return list(self._call_java("javaTreeWeights"))
--- End diff --
Can we not simply override the method for the case where it is a
classification model? I think that is only for RFClasaifier since GBT
actually returns DTRegreasionModels
On Thu, 5 May 2016 at 18:44, Holden Karau <[email protected]> wrote:
> In python/pyspark/ml/regression.py
> <https://github.com/apache/spark/pull/12919#discussion_r62215111>:
>
> > @@ -743,6 +743,18 @@ def treeWeights(self):
> > """Return the weights for each tree"""
> > return list(self._call_java("javaTreeWeights"))
> >
>
> So we could do that, the thing is it might be a
> DecisionTreeRegressionModel or a DecisionTreeClassificationModel so we
> probably just want to return a list of DecisionTreeModel instead.
>
> â
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/spark/pull/12919/files/6400e9e3d7e096b05475cca548e31aabca8cbaff#r62215111>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
