Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12790#discussion_r62393609
  
    --- Diff: python/pyspark/ml/pipeline.py ---
    @@ -89,9 +87,9 @@ def setParams(self, stages=None):
             setParams(self, stages=None)
             Sets params for Pipeline.
             """
    -        if stages is None:
    -            stages = []
             kwargs = self.setParams._input_kwargs
    +        if stages is None:
    +            kwargs['stages'] = []
    --- End diff --
    
    So almost all of our things explode if you call setParams with something 
set to None - it gets turned into null on  the Java side and that tends to 
explode. We could avoid copying None params over but we might want to do that 
more generally than just here (and I'd probably do that in a separate PR since 
I'm not super sure that is the right thing to do or if we just expect people to 
not use None unless they really explicitly mean it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to