Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12790#discussion_r62543286
  
    --- Diff: python/pyspark/ml/pipeline.py ---
    @@ -89,9 +87,9 @@ def setParams(self, stages=None):
             setParams(self, stages=None)
             Sets params for Pipeline.
             """
    -        if stages is None:
    -            stages = []
             kwargs = self.setParams._input_kwargs
    +        if stages is None:
    +            kwargs['stages'] = []
    --- End diff --
    
    Yah I guess since it was previously being checked it might be good to check 
(although switching it to only do this when explicitly set to none as your 
editted comment does probably makes sense). Maybe @sethah and or @davies / 
@yanboliang can weigh in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to