Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12919#discussion_r62719285
--- Diff: python/pyspark/ml/regression.py ---
@@ -743,6 +743,18 @@ def treeWeights(self):
"""Return the weights for each tree"""
return list(self._call_java("javaTreeWeights"))
--- End diff --
What is the advantage here of making tree ensemble models return regression
trees? I understand that it is regression in 3 out of 4 cases, but it seems
counterintuitive. Also, this property is left abstract in Scala and each of the
four subclasses implements their own. I think @holdenk's suggestion is more
general and more closely mirrors Scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
