Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12919#discussion_r63168240
  
    --- Diff: python/pyspark/ml/regression.py ---
    @@ -743,6 +743,18 @@ def treeWeights(self):
             """Return the weights for each tree"""
             return list(self._call_java("javaTreeWeights"))
     
    --- End diff --
    
    I don't feel so strongly about it, so happy to revert to @holdenk's 
suggested approach. It is more "boilerplate" to override each concrete class in 
the same way, but it does match the Scala side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to