Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12801#discussion_r63067480
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -523,13 +524,14 @@ class SessionCatalog(
        */
       def dropPartitions(
           tableName: TableIdentifier,
    -      parts: Seq[TablePartitionSpec],
    +      specs: Seq[TablePartitionSpec],
           ignoreIfNotExists: Boolean): Unit = {
    +    requirePartialMatchedPartitionSpec(specs, getTableMetadata(tableName))
    --- End diff --
    
    Wait, I thought the intention of this patch is to ban the partial matching, 
which is buggy in Hive? Looks like this just ensures that the user doesn't 
specify a column that is not a partitioned column here. Is that sufficient to 
bypass the bug in Hive that you were talking about?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to