Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13129#discussion_r63643069
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -252,7 +250,7 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0")
override val uid: String
model,
Array(0D),
Array(0D))
- return copyValues(model.setSummary(trainingSummary))
+ return model.setSummary(trainingSummary)
--- End diff --
@jkbradley It does not necessary to ```setParent``` at here, because we
have done it at ```Predictor.fit```
```
override def fit(dataset: Dataset[_]): M = {
// This handles a few items such as schema validation.
// Developers only need to implement train().
transformSchema(dataset.schema, logging = true)
copyValues(train(dataset).setParent(this))
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
