Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13129#discussion_r63687411
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -107,7 +107,7 @@ private[regression] trait
GeneralizedLinearRegressionBase extends PredictorParam
s"with ${$(family)} family does not support ${$(link)} link
function.")
}
val newSchema = super.validateAndTransformSchema(schema, fitting,
featuresDataType)
- if ($(linkPredictionCol).nonEmpty) {
+ if (isDefined(linkPredictionCol) && $(linkPredictionCol).nonEmpty) {
--- End diff --
This is used twice now, perhaps makes sense to make a `def
hasLinkPredictionCol` as for e.g. `hasQuantilesCol`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
