Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r63696847
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,15 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ for i in {1..10}
+ do
+ if [[ $(ps -p "$newpid" -o comm=) =~ "java" ]]; then
+ break
+ fi
+ sleep 0.5
--- End diff --
Maybe once a second for 5 seconds? you need to remove the "sleep 2" below.
Maybe you can use a variable rather than re-test the condition after the
loop?
However, the PR has also been messed up with some unrelated changes. Can
you fix or else open a new PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
