Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r63701914
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,15 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ for i in {1..10}
+ do
+ if [[ $(ps -p "$newpid" -o comm=) =~ "java" ]]; then
+ break
+ fi
+ sleep 0.5
--- End diff --
OK, that's fair, we still need to see if it dies. I suppose there could be
a second loop to keep watching for it to die, but in the normal case that still
requires waiting some number of seconds. This is OK, except for the PR problem
of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
