Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12979#discussion_r63743517
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -706,6 +712,20 @@ class CodegenContext {
if (doSubexpressionElimination) subexpressionElimination(expressions)
expressions.map(e => e.genCode(this))
}
+
+ /**
+ * Add a pair of a place holder and a corresponding comment
+ */
+ def addCommentEntry(placeHolder: String, comment: String): Unit = {
+ placeHolderToCommentMap += (placeHolder -> comment)
+ }
+
+ /**
+ * Copy an immutable map of the pair of a place holder and a
corresponding comment
+ */
+ def copyPlaceHolderToCommentMap(): immutable.Map[String, String] = {
--- End diff --
CodegenContext is not re-used, do we still need this copy?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
