Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/12979#discussion_r63750085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -97,15 +97,20 @@ abstract class Expression extends TreeNode[Expression] {
ctx.subExprEliminationExprs.get(this).map { subExprState =>
// This expression is repeated which means that the code to evaluate
it has already been added
// as a function before. In that case, we just re-use it.
- val code = s"/* ${toCommentSafeString(this.toString)} */"
- ExprCode(code, subExprState.isNull, subExprState.value)
+ val placeHolder = s"/*{${ctx.freshName("comment_placeholder")}}*/"
--- End diff --
Actually, `}` is really needed.
If we have place holders like `comment_placeholder1` and
`comment_placeholder12`, and the actual comment `Hello` corresponds to
`comment_placeholder1`, `comment_placeholder1` will be replaced with `Hello`
but also `comment_placeholder12` will be replaced with `Hello2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
