Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13192#discussion_r63913005
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
 ---
    @@ -24,13 +24,13 @@ package 
org.apache.spark.sql.catalyst.expressions.codegen
      * Written by Matei Zaharia.
      */
     object CodeFormatter {
    -  def format(code: String): String = new 
CodeFormatter().addLines(code).result()
    +  def format(code: String): String = new 
CodeFormatter().addLines(stripExtraNewLines(code)).result()
    --- End diff --
    
    We can't remove the empty lines here, or LINENO of the compiled code will 
be different than the formatted code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to