Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13192#discussion_r63913511
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
 ---
    @@ -124,6 +124,7 @@ object GenerateMutableProjection extends 
CodeGenerator[Seq[Expression], MutableP
     
             public java.lang.Object apply(java.lang.Object _i) {
               InternalRow ${ctx.INPUT_ROW} = (InternalRow) _i;
    +          /*** project list: 
${expressions.map(_.toCommentSafeString).mkString(", ")} */
    --- End diff --
    
    When there are many columns, the comments are far away from their code, 
it's better to interweave them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to